andy hayden
2018-08-19 03:49:02 UTC
Hi,
I am not sure if this is the correct place to post this, but the luci-go's
README <https://chromium.googlesource.com/infra/luci/luci-go> says "Contributing
uses the same flow as Chromium contributions
<https://www.chromium.org/developers/contributing-code>." ...
When installing v8 via GN using an Anaconda bundled python, luci-go throws
an exception.
See: https://github.com/denoland/deno/issues/542
I believe this is a bug in luci-go since it's trying to parse the python
version (major.minor.patch) from the command:
$ python --version
On my OSX system python this is "Python 2.7.12" but for Anaconda it's
"Python 2.7.15 :: Continuum Analytics, Inc.".
Similarly on Windows for which the bug report came in from.
Hence there's an exception
<https://github.com/luci/luci-go/blob/043220934aed46e9514844a3a1332792ad8b5254/vpython/python/interpreter_test.go#L95> when
parsed by luci-go: "non-canonical Python version string".
I believe the fix is to use platform.python_version
<https://docs.python.org/3/library/platform.html#platform.python_version>
instead of --version e.g.
$ python -c 'import platform; print(platform.python_version())'
2.7.15
Perhaps I am missing something, and please correct me if this is the wrong
thread.
I am happy to attempt a patch if that's an acceptable/desired fix.
Thanks,
Andy
I am not sure if this is the correct place to post this, but the luci-go's
README <https://chromium.googlesource.com/infra/luci/luci-go> says "Contributing
uses the same flow as Chromium contributions
<https://www.chromium.org/developers/contributing-code>." ...
When installing v8 via GN using an Anaconda bundled python, luci-go throws
an exception.
See: https://github.com/denoland/deno/issues/542
I believe this is a bug in luci-go since it's trying to parse the python
version (major.minor.patch) from the command:
$ python --version
On my OSX system python this is "Python 2.7.12" but for Anaconda it's
"Python 2.7.15 :: Continuum Analytics, Inc.".
Similarly on Windows for which the bug report came in from.
Hence there's an exception
<https://github.com/luci/luci-go/blob/043220934aed46e9514844a3a1332792ad8b5254/vpython/python/interpreter_test.go#L95> when
parsed by luci-go: "non-canonical Python version string".
I believe the fix is to use platform.python_version
<https://docs.python.org/3/library/platform.html#platform.python_version>
instead of --version e.g.
$ python -c 'import platform; print(platform.python_version())'
2.7.15
Perhaps I am missing something, and please correct me if this is the wrong
thread.
I am happy to attempt a patch if that's an acceptable/desired fix.
Thanks,
Andy
--
--
Chromium Discussion mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-discuss
---
You received this message because you are subscribed to the Google Groups "Chromium-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-discuss+***@chromium.org.
--
Chromium Discussion mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-discuss
---
You received this message because you are subscribed to the Google Groups "Chromium-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-discuss+***@chromium.org.